Add action to create a module release PR #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Dec 19, 2024
bastelfreak
force-pushed
the
prep
branch
2 times, most recently
from
eb2e843 to
672a436
Compare
ekohl
reviewed
Dec 19, 2024
ekohl
reviewed
Dec 19, 2024
bastelfreak
force-pushed
the
prep
branch
2 times, most recently
from
db2ad4d to
09a0cb5
Compare
ekohl
reviewed
Dec 19, 2024
ekohl
reviewed
Dec 19, 2024
ekohl
reviewed
Dec 19, 2024
evgeni
reviewed
Dec 19, 2024
evgeni
reviewed
Dec 19, 2024
bastelfreak
force-pushed
the
prep
branch
2 times, most recently
from
64eaaf5 to
0d0c225
Compare
ekohl
reviewed
Dec 21, 2024
bastelfreak
force-pushed
the
prep
branch
2 times, most recently
from
2114a18 to
467cb1f
Compare
evgeni
reviewed
Dec 22, 2024
bastelfreak
force-pushed
the
prep
branch
5 times, most recently
from
166c090 to
e3c3bba
Compare
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
bastelfreak
commented
Dec 22, 2024
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: |
There was a problem hiding this comment.
Perforce makes a full clone with:
- name: "Checkout"
uses: "actions/checkout@v4"
with:
fetch-depth: 0In my tests that wasn't required. Maybe it's for some edge cases. Based on their git history I didn't find any explanation.
|
Tested successfully at voxpupuli/puppet-example#82 . Followup PR for the optional input: voxpupuli/puppet-example#83 |
jay7x
approved these changes
Dec 22, 2024
ekohl
reviewed
Dec 22, 2024
| # https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication | ||
| CHANGELOG_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: bundle exec rake release:prepare | ||
| - name: Create pull Request |
There was a problem hiding this comment.
Looking at voxpupuli/puppet-example#82 I wonder if we can come up with some better instructions in the body. For example, it could link to https://voxpupuli.org/docs/releasing_version/ though that isn't really explaining it well for this new process.
There was a problem hiding this comment.
My idea was to link to https://voxpupuli.org/docs/releasing_version/ and update it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.